cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bso-intel <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...
Date Thu, 03 Mar 2016 16:15:27 GMT
Github user bso-intel commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/402#discussion_r54902889
  
    --- Diff: cordova-lib/src/plugman/install.js ---
    @@ -71,7 +71,8 @@ module.exports = function installPlugin(platform, project_dir, id, plugins_dir,
         project_dir = cordovaUtil.convertToRealPathSafe(project_dir);
         plugins_dir = cordovaUtil.convertToRealPathSafe(plugins_dir);
         options = options || {};
    -    options.is_top_level = true;
    +    if (options.is_top_level === undefined)
    --- End diff --
    
    I changed as you suggested.
    Do you mean you want to set options.is_top_level = true if options.is_top_level is set
to null ?
    In fact, the is_top_level is a boolean property, so a null value for this property is
a bug although null is falsy in Javascript.
    When options.is_top_level is set to null for some reason, options.hasOwnProperty('is_top_level')
is  true.
    That means, the new condition (options.hasOwnProperty('is_top_level') === false) will
not change options.is_top_level from the null value to true.
    Just wanted clarify.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message