cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-docs pull request: CB-10178 Fix a number of documentation ...
Date Thu, 03 Mar 2016 03:07:09 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/528#discussion_r54830785
  
    --- Diff: www/docs/en/dev/config_ref/images.md ---
    @@ -42,79 +45,107 @@ density       | *Optional* <br/> Specified icon density (Android
Specific)
     
     The following configuration can be used to define single default icon
     which will be used for all platforms.
    -
    -        <icon src="res/icon.png" />
    -
    +```xml
    +    <icon src="res/icon.png" />
    +```
     For each platform you can also define a pixel-perfect icons set to fit
     different screen resolutions.
     
     ##Android
    -
    -         <platform name="android">
    -                  <icon src="res/android/ldpi.png" density="ldpi" />
    -                  <icon src="res/android/mdpi.png" density="mdpi" />
    -                  <icon src="res/android/hdpi.png" density="hdpi" />
    -                  <icon src="res/android/xhdpi.png" density="xhdpi" />
    -         </platform>
    +```xml
    +    <platform name="android">
    +        <!-- 
    +            ldpi    : 36x36 px
    +            mdpi    : 48x48 px
    +            hdpi    : 72x72 px
    +            xhdpi   : 96x96 px
    +            xxhdpi  : 144x144 px
    +            xxxhdpi : 192x192 px
    +        -->
    +        <icon src="res/android/ldpi.png" density="ldpi" />
    +        <icon src="res/android/mdpi.png" density="mdpi" />
    +        <icon src="res/android/hdpi.png" density="hdpi" />
    +        <icon src="res/android/xhdpi.png" density="xhdpi" />
    +        <icon src="res/android/xxhdpi.png" density="xxhdpi" />
    +        <icon src="res/android/xxxhdpi.png" density="xxxhdpi" />
    +    </platform>
    +```
    +###See Also
    +- [Android icon guide](https://www.google.com/design/spec/style/icons.html)
    +- [Android - Supporting multiple screens](http://developer.android.com/guide/practices/screens_support.html)
    --- End diff --
    
    Can you comment on why it is better in this case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message