cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-plugin-battery-status pull request: Reorganizing and rewor...
Date Wed, 02 Mar 2016 18:01:40 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-battery-status/pull/33#discussion_r54763344
  
    --- Diff: README.md ---
    @@ -57,120 +60,81 @@ attach an event listener after the `deviceready` event fires.
     - BlackBerry 10
     - Windows Phone 7 and 8
     - Windows (Windows Phone 8.1 only)
    -- Tizen
     - Firefox OS
    -- Browser
    +- Browsers
    +    - Chrome
    +    - Firefox
    +    - Opera
     
    -### Android and Amazon Fire OS Quirks
    +### Quirks: Android &amp; Amazon Fire OS
     
    -- Warning: the Android + Fire OS implementations are greedy and prolonged use will drain
the user's battery. 
    +**Warning**: the Android and Fire OS implementations are greedy and prolonged use will
drain the device's battery.
     
    -### Windows Phone 7 and 8 Quirks
    +### Quirks: Windows Phone 7 &amp; Windows Phone 8
     
    -Windows Phone 7 does not provide native APIs to determine battery
    -level, so the `level` property is unavailable.  The `isPlugged`
    -parameter _is_ supported.
    +The `level` property is _not_ supported on Windows Phone 7 because the OS does not provide
native APIs to determine battery level. The `isPlugged` parameter _is_ supported.
     
    -### Windows Quirks
    +### Quirks: Windows &amp; Windows Phone 8.1
    --- End diff --
    
    I think the quirk only applies to Windows Phone 8.1 as stated and not to Windows platform
overall which includes Windows 8.1, Windows Phone 8.1 & Windows 10. Does your edit change
the meaning?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message