cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dieppe <>
Subject [GitHub] cordova-plugin-camera pull request: [iOS] Major refactor
Date Wed, 02 Mar 2016 16:23:02 GMT
Github user dieppe commented on a diff in the pull request:
    --- Diff: src/ios/CDVCamera.m ---
    @@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
         return filePath;
    +// This is not absolute, but more mightNeedOrientationCorrection
    +- (BOOL) needsOrientationCorrection:(UIImage*)image options:(CDVPictureOptions*)options
    --- End diff --
    Agreed. The only reason this is a function is because I wanted to check:
    - if the image really needed an orientation correction (but that is an over optimization),
    - if we really wanted to correct gallery image orientation.
    Anyway, will be inlined.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message