cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <>
Subject [GitHub] cordova-plugin-camera pull request: [iOS] Major refactor
Date Wed, 02 Mar 2016 06:29:50 GMT
Github user omefire commented on a diff in the pull request:
    --- Diff: src/ios/CDVCamera.m ---
    @@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
         return filePath;
    +// This is not absolute, but more mightNeedOrientationCorrection
    +- (BOOL) needsOrientationCorrection:(UIImage*)image options:(CDVPictureOptions*)options
    --- End diff --
    We don't need a separate function for this, I think we can have these options 'inline'
where needed instead of creating separate functions for them.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message