cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <>
Subject [GitHub] cordova-plugin-camera pull request: [iOS] Major refactor
Date Wed, 02 Mar 2016 05:10:50 GMT
Github user omefire commented on a diff in the pull request:
    --- Diff: src/ios/CDVCamera.m ---
    @@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
         [self.commandDelegate runInBackground:^{
             CDVPictureOptions* pictureOptions = [CDVPictureOptions createFromTakePictureArguments:command];
    +        /*
    +         FIXME #1
    +         What to do about quality?
    --- End diff --
    I think if the quality option is specified, we need to modify the image retrieved from
the PhotoLibraryr or SavedAlbum & (re)save it with the specified quality, then send a
'reference' back to the newly saved image.
    This looks like a potential change in the API and might need to be ran past the dev mailing

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message