cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: [iOS] Major refactor
Date Tue, 01 Mar 2016 19:28:15 GMT
Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54620911
  
    --- Diff: src/ios/CDVCamera.h ---
    @@ -87,19 +91,51 @@ typedef NSUInteger CDVMediaType;
     {}
     
     @property (strong) CDVCameraPicker* pickerController;
    -@property (strong) NSMutableDictionary *metadata;
    +@property (strong) NSDictionary* metadata;
     @property (strong, nonatomic) CLLocationManager *locationManager;
    -@property (strong) NSData* data;
    +@property (strong) UIImage* image;
     
     /*
    - * getPicture
    + * takePicture
      *
      * arguments:
    - *	1: this is the javascript function that will be called with the results, the first
parameter passed to the
    - *		javascript function is the picture as a Base64 encoded string
    - *  2: this is the javascript function to be called if there was an error
    + *  1: success callback (called with either Base64, file URI or native URI)
    --- End diff --
    
    These comments seem to be meant to document the javascript side of things, instead of
the objective-c side. What's the reason for them being here ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message