cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...
Date Tue, 01 Mar 2016 13:15:33 GMT
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-android/pull/264#issuecomment-190719953
  
    @bso-intel, IMO there is a reason for current approach - `<source-file>` element
is intended to handle `.java`, `.m` and other types of source files - not binary packages
or the whole directories. In case of source files silently overwrite conflicting files might
be a bad idea which might cause build-time failures.
    
    I think in your case it's more appropriate to use `<resource-file>` element which
also have `target` attribute to specify exact target location of copied files and uses `copyFile`
internally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message