cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-10729 Move plugin handlers tests ...
Date Tue, 01 Mar 2016 07:42:37 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/265#discussion_r54531747
  
    --- Diff: bin/templates/cordova/lib/pluginHandlers.js ---
    @@ -31,7 +31,7 @@ var handlers = {
                 if (!obj.src) throw new CordovaError('<source-file> element is missing
"src" attribute for plugin: ' + plugin.id);
                 if (!obj.targetDir) throw new CordovaError('<source-file> element is
missing "target-dir" attribute for plugin: ' + plugin.id);
                 var dest = path.join(obj.targetDir, path.basename(obj.src));
    -            copyNewFile(plugin.dir, obj.src, project.projectDir, dest, options &&
options.link);
    +            copyNewFile(plugin.dir, obj.src, project.projectDir, dest, !!(options &&
options.link));
    --- End diff --
    
    Just some divergence between expected spy arguments and actual ones, Not a bug probably,
but i preferred to change parameter type rather than tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message