Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 70FE618E5A for ; Wed, 24 Feb 2016 10:31:28 +0000 (UTC) Received: (qmail 60266 invoked by uid 500); 24 Feb 2016 10:31:28 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 60227 invoked by uid 500); 24 Feb 2016 10:31:28 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 60215 invoked by uid 99); 24 Feb 2016 10:31:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Feb 2016 10:31:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BFED5DFFC0; Wed, 24 Feb 2016 10:31:27 +0000 (UTC) From: daserge To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins Content-Type: text/plain Message-Id: <20160224103127.BFED5DFFC0@git1-us-west.apache.org> Date: Wed, 24 Feb 2016 10:31:27 +0000 (UTC) Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53919580 --- Diff: src/firefoxos/FileProxy.js --- @@ -67,10 +69,12 @@ QUIRKS: exports.requestFileSystem = function(successCallback, errorCallback, args) { var type = args[0]; - var size = args[1]; + //var size = args[1]; --- End diff -- This var is not used, although it would be useful to leave it as a comment in terms of the function signature definition. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org