Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: riknoll <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-160-cordova-plugin-camera@git.apache.org>
In-Reply-To: <git-pr-160-cordova-plugin-camera@git.apache.org>
Subject: [GitHub] cordova-plugin-camera pull request: CB-10270 android: Added
 back s...
Content-Type: text/plain
Message-Id: <20160209183915.15733E031B@git1-us-west.apache.org>
Date: Tue,  9 Feb 2016 18:39:15 +0000 (UTC)

Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-181996971
  
    Alright, the real solution to this problem in my opinion is to get rid of the `getRealPath` function altogether. Not all URIs have real paths and there are always going to be some cases that fail. The "Android" way of handling this is to use ContentResolvers in order to get input streams and to stop trying to force everything into being a file on the device. Unfortunately, that is a major rewrite of this plugin. The sheer number of JIRA issues and open PRs that deal with it should be justification enough, though.
    
    As for this PR, it does patch over one issue and so I'm inclined to leave it open as is. The other issue you are seeing is related but requires a very different fix. I believe there is already a JIRA open tracking it but I can't recall the issue ID off the top of my head.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org