Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: nikhilkh <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-471-cordova-docs@git.apache.org>
In-Reply-To: <git-pr-471-cordova-docs@git.apache.org>
Subject: [GitHub] cordova-docs pull request: CB-10332 Android Guide
 Improvements
Content-Type: text/plain
Message-Id: <20160204060025.6893DDFCE4@git1-us-west.apache.org>
Date: Thu,  4 Feb 2016 06:00:25 +0000 (UTC)

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/471#discussion_r51832927
  
    --- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
    @@ -31,12 +31,12 @@ platform and back.  For another sample, see also the comments in
     [CordovaPlugin.java](https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaPlugin.java).
     
     Android plugins are based on Cordova-Android, which consists of an
    -Android WebView with hooks attached to it.  Plugins are represented as
    -class mappings in the `config.xml` file.  A plugin consists of at
    +Android WebView with hooks attached to it. Plugins are represented as
    +class mappings in the `config.xml` file. A plugin consists of at
     least one Java class that extends the `CordovaPlugin` class,
    -overriding one of its `execute` methods. As best practice, the plugin
    -should also handle `[pause](../../../cordova/events/events.pause.html)` and `[resume](../../../cordova/events/events.resume.html)` events, along with any message
    -passing between plugins.  Plugins with long-running requests,
    +overriding one of its `execute` methods. As a best practice, the plugin
    +should also handle [`pause`](../../../cordova/events/events.pause.html) and [`resume`](../../../cordova/events/events.resume.html) events, along with any message
    --- End diff --
    
    Should you link to android lifecyle here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org