cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpolivy <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: CB-10692 Don't fade when...
Date Thu, 25 Feb 2016 01:05:05 GMT
GitHub user dpolivy opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/86

    CB-10692 Don't fade when plugin is forced to close

    The fading logic exposed a race condition in an edge case when the
    plugin was repeatedly reinitialized, e.g. when the WebView tries to load
    a new URL. To address this, we add a flag to removeSplashScreen() that
    allows the fade logic to be bypassed in certain circumstances --
    specifically, when hiding the splashscreen due to onPause or onDestroy
    events. By hiding it immediately in this scenario, we can avoid any race
    conditions due to the fade delay.
    
    Fixes https://issues.apache.org/jira/browse/CB-10692

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpolivy/cordova-plugin-splashscreen CB10692

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #86
    
----
commit 48bb4ad4532d960bd6b40b382f915089b726ed26
Author: Dan Polivy <dan@cellartracker.com>
Date:   2016-02-25T01:03:58Z

    CB-10692 Don't fade when plugin is forced to close
    
    The fading logic exposed a race condition in an edge case when the
    plugin was repeatedly reinitialized, e.g. when the WebView tries to load
    a new URL. To address this, we add a flag to removeSplashScreen() that
    allows the fade logic to be bypassed in certain circumstances --
    specifically, when hiding the splashscreen due to onPause or onDestroy
    events. By hiding it immediately in this scenario, we can avoid any race
    conditions due to the fade delay.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message