cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TanaseButcaru <...@git.apache.org>
Subject [GitHub] cordova-plugin-media-capture pull request: Fix MediaFile.getFormat...
Date Sat, 13 Feb 2016 15:38:50 GMT
GitHub user TanaseButcaru opened a pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/53

    Fix MediaFile.getFormatData on Android (readded)

    JIRA Issue [CB-10488](https://issues.apache.org/jira/browse/CB-10488)
    JIRA Issue [CB-10489](https://issues.apache.org/jira/browse/CB-10489)
    
    Also resolves this one #43  / [CB-9611](https://issues.apache.org/jira/browse/CB-9611)
    
    -------------
    1. ``getFormatData`` was not working at all on Android (and iOS) because it was using
the ``localURL`` instead of ``fullPath``
    2. audio recording was not even checking for metadata because the current code is only
searching for .3gpp audio files, but the default recording file type for android is ``audio/amr``.
 
    On my android 4.4, the Sound Recorder app has options from where the user can change the
output file type (it has wav, amr & 3gpp); some devices are recording aac too.   
    All these file types for audio recording are now supported.
    3.  Related CB-9611 (PR#43) resolved without hardcoded ``file://`` string.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TanaseButcaru/cordova-plugin-media-capture-unofficial MediaFile-getFormat-20160213

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media-capture/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit 988cad058e14ec8518902d52baae447409aaa20e
Author: TanaseButcaru <contact@butcaru.com>
Date:   2016-01-31T22:42:07Z

    Fix for MediaFile.getFormatData

commit e8b7fc5e6f5c4d4077646847999daaccba6f852d
Author: TanaseButcaru <contact@butcaru.com>
Date:   2016-02-03T21:49:06Z

    Fix for MediaFile.getFormatData / audio recording support

commit 5fb509da851ccb2bc320776fa037975a365b80ed
Author: Tanase Butcaru <tanasebutcaru@users.noreply.github.com>
Date:   2016-02-12T09:20:43Z

    Merge pull request #1 from apache/master
    
    chore: edit package.json license to match SPDX id

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message