cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bso-intel <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...
Date Sun, 28 Feb 2016 16:07:26 GMT
GitHub user bso-intel opened a pull request:

    https://github.com/apache/cordova-lib/pull/402

    CB-10328 set top-level property of plugins when adding new platforms

    The problem is caused by not setting the top-level property of plugins from cordova/platform.js-installPluginsForNewPlatform()
function and by always setting is_top_level to true in plugman/install.js-installPlugin.
    This caused all plugins that exist in the plugins directory to be set top-level in plugins/<platform>.json
files.
    The uninstallation process relies on this metadata file to see if there is any dependency
plugin was installed when removing a top-level plugin.
    By setting the top-level correctly in <platform>.json files, this uninstallation
process worked correctly.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bso-intel/cordova-lib CB-10328

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/402.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #402
    
----
commit c7b3f4e5ce74c4cf79c14fa8239ad7a7cc07ebfe
Author: Byoungro So <byoungro.so@intel.com>
Date:   2016-02-28T15:59:49Z

    CB-10328 set top-level property of plugins when adding new platforms

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message