cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sajacy <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10658: Downgrade error to warning
Date Sun, 21 Feb 2016 16:40:37 GMT
GitHub user sajacy opened a pull request:

    https://github.com/apache/cordova-lib/pull/397

    CB-10658: Downgrade error to warning

    Replace error with warning message if search paths differ.
    (which does happen with `cca` tool from the MobileChromeApps project)
    
    Generally, if the `localPlugins` cache variable has been previously set, 
    (e.g. via programmatically calling plugin add), then subsequent calls with
    differing paths will cause the process to exit, which seems a bit extreme.
    As the comments suggest, this is simply not implemented, not a failure 
    state, and can be safely passed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sajacy/cordova-lib patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/397.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #397
    
----
commit c1d985855049fa844d2823d9e0d0c81447fc92d8
Author: Jeffrey Yang <jeffrey.a.yang@gmail.com>
Date:   2016-02-21T15:44:13Z

    Downgrade error to warning
    
    Replace error with warning message if search paths differ.
    (which does happen with `cca` tool from the MobileChromeApps project)
    
    Generally, if the `localPlugins` cache variable has been previously set, 
    (via programmatically calling plugin add), then subsequent calls with
    differing paths will cause the process to exit, which seems a bit extreme.
    As the comments suggest, this is simply not implemented, not a failure 
    state, and can be safely passed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message