cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10519 Wrap all sync calls inside of `...
Date Wed, 10 Feb 2016 14:52:16 GMT
GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-lib/pull/384

    CB-10519 Wrap all sync calls inside of `cordova.raw` methods into promises

    This is a fix for [CB-10519](https://issues.apache.org/jira/browse/CB-10519)
    
    This PR fixes the issue when promise returned from `cordova.raw` API would never be rejected
if command is ran outside of cordova project. Instead syncronous exception will be thrown
(by `util.preProcessOptions`), which is definitely unexpected for promise based API.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-10519

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #384
    
----
commit 747c26e64a491645fad1dd109afb734bc9a5ce4a
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2016-02-10T12:45:19Z

    CB-10519 Wrap all sync calls inside of `cordova.raw` methods into promises

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message