cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10430 Adds forwardEvents method to ea...
Date Tue, 09 Feb 2016 15:14:33 GMT
GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-lib/pull/382

    CB-10430 Adds forwardEvents method to easily connect two EventEmitters

    This fixes CB-10430.
    
    This change is needed to allow platform connect own `events` instance to another, provided
by caller (`cordova-lib` in most cases)
    
    This PR is a replacement for #370 
    
    A usage sample:
    ```javascript
    function Api(platform, platformRootDir, eventEmitter) {
        ...
        if (eventEmitter) {
            events.forwardEventsTo(eventEmitter);
        } else {
            CordovaLogger.get().subscribe(events);
        }
        ...
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-10430

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #382
    
----
commit 426e3a9e15b6c32c67f1173b8b71e8d6ba551b45
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2016-02-09T06:26:52Z

    CB-10430 Adds forwardEvents method to easily connect two EventEmitters

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message