cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pbakondy <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Prefer .bat over .cmd on windows platfor...
Date Mon, 01 Feb 2016 17:24:31 GMT
GitHub user pbakondy opened a pull request:

    https://github.com/apache/cordova-lib/pull/371

    Prefer .bat over .cmd on windows platform

    Fixes ant-running issue on windows platform.
    
    Originally I wanted to build android platform with ant:
    
    ```
    cordova build android -- --ant
    ```
    
    The downloadable Ant distribution package contains `ant.bat` and `ant.cmd` files in the
`bin` directory.
    
    The `resolveWindowsExe()` function resolves `ant` to `%ANT_HOME%\\bin\\ant.cmd`.
    
    In case of ant this is not correct because `ant.cmd` is made for OS/2 platform ( see:
https://ant.apache.org/manual/running.html )
    
    `child_process.spawn()` should run `ant.bat` file instead of `ant.cmd`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pbakondy/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #371
    
----
commit 9ffcdcc3a00bbc90cdd4f45c29be0d5d2465a023
Author: Peter Bakondy <pbakondy@gmail.com>
Date:   2016-02-01T17:22:22Z

    Prefer .bat over .cmd on windows platform
    
    Fixes ant-running issue on windows platform.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message