cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-10510: Add an optional timeout to...
Date Thu, 11 Feb 2016 22:00:43 GMT
GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-android/pull/258

    CB-10510: Add an optional timeout to emu start script

    The `emulator.js` script waits forever for the emulator to boot. If the emulator gets
stuck, it will never terminate. The reason for adding this timeout is that the Android emulator
on Windows occasionally hangs while booting up. This causes problems in our CI, where the
run step would go on forever until buildbot eventually cut it off (see [here](https://ci.apache.org/builders/cordova-android-win/builds/1588/steps/running-tests/logs/stdio)
for an example run). I have an upcoming PR for cordova-medic that switches from using `cordova
run` to start the emulator to requiring this script directly so that we can add retry logic
for the emulator start. I don't think it really makes sense to expose the timeout option in
the CLI itself, so this PR does not alter the CLI's behavior at all (it will still hang).
I'm not sure if we should add in a default timeout or not.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-android CB-10510

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #258
    
----
commit 723393168127524f5f23d931bbcf171edbd08d39
Author: riknoll <richard.b.knoll@gmail.com>
Date:   2016-02-11T21:37:00Z

    CB-10510: Add an optional timeout to emu start script
    
    The script used to wait forever for the emulator to boot.
    If the emulator got stuck, it would never terminate.
    This timeout is being added to support cordova-medic and
    the CI.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message