cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benconnito <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: fixes for CB-10184 and CB-10493
Date Sat, 06 Feb 2016 16:16:28 GMT
GitHub user benconnito opened a pull request:

    https://github.com/apache/cordova-ios/pull/191

    fixes for CB-10184 and CB-10493

    these two bugs prevent the submission of ios apps to itc. tests pass. comments on fixes
welcome.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benconnito/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #191
    
----
commit c484a8f8f45ec13ee4fad54635fce76e09a31d79
Author: Ben Connito <ben.connito@exponentialent.com>
Date:   2016-02-06T15:58:17Z

    CB-10184: Images.xcassets: A 83.5x83.5@2x app icon is required for iPad apps targeting
iOS 9.0 and later
    
    added image to project template
    added destination to prepare.js

commit 419cffaeab548a3a2eca8653b7e4234769fbb41f
Author: Ben Connito <ben.connito@exponentialent.com>
Date:   2016-02-06T16:01:24Z

    added to ipad pro image definition to contents.json

commit c9514f478e2523268659967ed00c127f67ddbc99
Author: Ben Connito <ben.connito@exponentialent.com>
Date:   2016-02-06T16:04:27Z

    CB-10493: [iOS] Missing icon.png
    
    removed key CFBundleIconFile and string icon.png. This fixes the itc submission error
that this file is missing.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message