cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-10120 android: Camera permi...
Date Thu, 25 Feb 2016 20:34:35 GMT
GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/179

    CB-10120 android: Camera permission must be requested when present in Manifest

    Because three PRs are better than one.
    
    This provides fixes for #142 and is based on top of the rebase in #174 
    
    I will merge this in later today

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-10120rebase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #179
    
----
commit 345647586b6d2bf410b1ebf16f631e5a8cf9a591
Author: ochakov <evgeny@ochakov.com>
Date:   2015-12-01T21:10:43Z

    CB-10120 android: Fix missing CAMERA permission for Android M
    
    According to the PR conversation, when android.permission.CAMERA
    is not set in the package, there is no need to ask for the
    camera permission. Also, checking now camera and storage
    permissions separately, so if only one of them is missing, the
    other one will be requested and not both.
    
    Rebased by MatthewBooth and riknoll
    
    This closes #142, closes #174

commit fe02f182d7a157856ec71cca33923c84aba92406
Author: riknoll <richard.b.knoll@gmail.com>
Date:   2016-02-24T22:51:52Z

    CB-10120 android: Fixing use of constants and PermissionHelper

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message