cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MatthewBooth <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Date Fri, 19 Feb 2016 17:19:06 GMT
GitHub user MatthewBooth opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/174

    Rebased ochakov's branch to the latest as of writing

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MatthewBooth/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #174
    
----
commit 91dd693623ae17c84d5d8e3e27139247b2b59690
Author: ochakov <evgeny@ochakov.com>
Date:   2015-12-01T21:10:43Z

    Fix missing CAMERA permission for Android M
    
    Fixing a bug where for Android M new permissions model, only external storage permission
was asked, while camera permission was not, causing camera to fail on Android 6.0

commit 70fcf30423946ec9d3299be1495ddd44cacff3c1
Author: ochakov <evgeny@ochakov.com>
Date:   2015-12-01T21:34:08Z

    Fix requiring both Camera and Storage permissions
    
    To take a picture on Android M, both Camera and Storage access permissions are required.
Now asking for both permissions simultaneously.

commit c4618a894eec92349371221fe18b5572151bff6f
Author: ochakov <evgeny@ochakov.com>
Date:   2015-12-02T23:51:22Z

    Check android.permission.CAMERA in the package
    
    According to the PR conversation, when android.permission.CAMERA is not set in the package,
there is no need to ask for the camera permission. Also, checking now camera and storage permissions
separately, so if only one of them is missing, the other one will be requested and not both.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message