cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...
Date Mon, 01 Feb 2016 22:21:44 GMT
GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/160

    CB-10270 android: Added back support for file:// URIs to getRealPath

    Our `getRealPath()` function is unable to handle `file: //` URIs, which can occasionally
lead it to return an empty string for the result URI. These camera options reproduce when
you select an image from the Gallery app:
    ```
    {
        destinationType: Camera.DestinationType.FILE_URI,
        sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
        allowEdit: true,
        correctOrientation: true
    }
    ```
    I believe that we used to do something similar to this, but it was removed at some point
in the past. @infil00p do you have any idea why that was?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-10270

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #160
    
----
commit ee06d3efb233d5404d0aeda2abe08e6fd765c7fe
Author: riknoll <richard.b.knoll@gmail.com>
Date:   2016-01-29T23:47:00Z

    CB-10270 android: Added back support for file:// URIs to getRealPath

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message