cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse <purplecabb...@gmail.com>
Subject Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos
Date Mon, 01 Feb 2016 23:21:42 GMT
This looks good, as a metric to add.
What is the impact to our workflow? are we just adding a node dependency,
or are there other config/integration parts that we need to do?




@purplecabbage
risingj.com

On Mon, Feb 1, 2016 at 2:17 PM, Steven Gill <stevengill97@gmail.com> wrote:

> Hey Vlad!
>
> This looks great! You are using istanbul for code coverage it seems.
>
> Why did you remove spec-cordova in your pr? Your [2]
>
> I think it is a great idea to include this in our repos. It would be nice
> to track our coverage and work on improving it.
>
> Though I do believe it is important not to chase 100% code coverage.
>
>
> On Mon, Feb 1, 2016 at 6:21 AM, Vladimir Kotikov (Akvelon) <
> v-vlkoti@microsoft.com> wrote:
>
> > Hey, guys
> >
> > I've spent a couple of hours and have a prototype of how we can
> visualize,
> > track and analyze code coverage for our repos.
> > Here is the fork of cordova-lib repo integrated with codecov.io [1]
> > (notice the coverage badge at the top of README), and a PR with some
> > coverage metrics [2]. The coverage summary is placed here [3]
> >
> > If this proposal get accepted, I'd like to enable this feature for all
> our
> > repos, to encourage contributors to increase current test coverage up to
> > appropriate values.
> >
> > It'd be great if anyone could give any feedback on this
> >
> > [1] https://github.com/vladimir-kotikov/cordova-lib
> > [2] https://github.com/vladimir-kotikov/cordova-lib/pull/2
> > [3] https://codecov.io/github/vladimir-kotikov/cordova-lib
> >
> > -
> > Best regards, Vladimir
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message