cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...
Date Fri, 26 Feb 2016 10:00:40 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/396#discussion_r54224163
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -135,13 +135,32 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
                 var splitVersion = plugin_src.split('@');
                 var newID = pluginMapperotn[splitVersion[0]];
                 if(newID) {
    -                events.emit('warn', 'Notice: ' + splitVersion[0] + ' has been automatically
converted to ' + newID + ' to be fetched from npm. This is due to our old plugins registry
shutting down.');
                     plugin_src = newID;
                     if (splitVersion[1]) {
                         plugin_src += '@'+splitVersion[1];
                     }
    -            } 
    -            return registry.fetch([plugin_src])
    +            }
    +            var P, skipCopyingPlugin;
    +            plugin_dir = path.join(plugins_dir, splitVersion[0]);
    --- End diff --
    
    It looks like these checks were already done in `plugman/install.js`. If we get here then
neither `plugins_dir/<oldId>` nor `plugins_dir/<newId>`shouldn't exist, or i'm
missing something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message