cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...
Date Thu, 25 Feb 2016 11:05:08 GMT
Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/398#discussion_r54079687
  
    --- Diff: cordova-lib/src/plugman/platforms/browser.js ---
    @@ -31,25 +29,7 @@ module.exports = {
             return path.join(project_dir, 'www');
         },
         package_name:function(project_dir) {
    -        // preferred location if cordova >= 3.4
    -        var preferred_path = path.join(project_dir, 'config.xml');
    -        var config_path;
    -
    -        if (!fs.existsSync(preferred_path)) {
    -            // older location
    -            var old_config_path = path.join(module.exports.www_dir(project_dir), 'config.xml');
    -            if (!fs.existsSync(old_config_path)) {
    -                // output newer location and fail reading
    -                config_path = preferred_path;
    -                events.emit('verbose', 'unable to find '+config_path);
    -            } else {
    -                config_path = old_config_path;
    -            }
    -        } else {
    -            config_path = preferred_path;
    -        }
    -        var widget_doc = xml_helpers.parseElementtreeSync(config_path);
    -        return widget_doc._root.attrib['id'];
    +        return common.package_name(project_dir);
    --- End diff --
    
    Perhaps should make the same change for `firefoxos` and `webos` (and maybe `blackberry10`)
too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message