cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...
Date Wed, 24 Feb 2016 23:03:23 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/516#discussion_r54022946
  
    --- Diff: gulpfile.js ---
    @@ -211,8 +203,10 @@ gulp.task("watch", ["serve"], function () {
         gulp.watch(
             [
                 path.join(ROOT_DIR, "**", "*.yml"),
    -            path.join(SOURCE_DIR, "**", "*.html"),
    -            path.join(SOURCE_DIR, "**", "*.md"),
    +            path.join(SOURCE_DIR, "**", "*.html") + "!" + path.join(DOCS_DIR, "**"),
    +            path.join(SOURCE_DIR, "**", "*.md") + "!" + path.join(DOCS_DIR, "**") ,
    +            path.join(DOCS_DIR, "en", "dev", "**", "*.md") ,
    +            path.join(DOCS_DIR, "en", "dev", "**", "*.html"),
    --- End diff --
    
    I didn't realise that although the docs folder is excluded, the English folder is included
explicitly. Could you please add a comment to draw attention to these two includes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message