cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins
Date Wed, 24 Feb 2016 09:12:27 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53911054
  
    --- Diff: tests/tests.js ---
    @@ -3040,20 +3045,19 @@ exports.defineAutoTests = function () {
                         expect(entries[0].toNativeURL).toBeDefined();
                         expect(typeof entries[0].toNativeURL).toBe('function');
                         var nativeURL = entries[0].toNativeURL();
    -                    var indexOfRoot = isWindows ? nativeURL.indexOf(":") :
    -                                      isChrome ? 'filesystem:file://'.length : // Chrome
uses own prefix for all filesystem urls
    -                                      7; //default value - length of 'file://' string
                         expect(typeof nativeURL).toBe("string");
                         expect(nativeURL.substring(0, pathExpect.length)).toEqual(pathExpect);
                         expect(nativeURL.substring(nativeURL.length - fileName.length)).toEqual(fileName);
                         // cleanup
    +                    // TODO: debug this
    --- End diff --
    
    Please either address this TODO or remove this line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message