cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <>
Subject [GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...
Date Tue, 23 Feb 2016 04:27:34 GMT
Github user dblotsky commented on a diff in the pull request:
    --- Diff: appium-tests/android/android.spec.js ---
    @@ -1,28 +1,34 @@
    -/*jslint node: true, plusplus: true */
    +/*jshint node: true */
     /*global beforeEach, afterEach */
     /*global describe, it, xit, expect, jasmine */
    -'use strict';
     // these tests are meant to be executed by Cordova Medic Appium runner
     // you can find it here:
     // it is not necessary to do a full CI setup to run these tests
     // just run "node cordova-medic/medic/medic.js appium --platform android --plugins cordova-plugin-camera"
    +'use strict';
     var wdHelper = require('../helpers/wdHelper');
     var wd = wdHelper.getWD();
     var cameraConstants = require('../../www/CameraConstants');
     var cameraHelper = require('../helpers/cameraHelper');
    +var screenshotHelper = require('../helpers/screenshotHelper');
     describe('Camera tests Android.', function () {
    +    var STARTING_MESSAGE = 'Ready for action!',
    +        RETRY_COUNT = 3, // how many times to retry taking a picture before failing
    +        MINUTE = 60 * 1000;
    --- End diff --
    Please put these outside of function scope. Nitpick: please have one declaration per line.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message