cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpolivy <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: CB-10263 Fix splashscree...
Date Sat, 20 Feb 2016 02:09:40 GMT
Github user dpolivy commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-186485912
  
    @daserge Have you tested this and verified it's working? I have the splashscreen plugin
v3.2.0, and have manually converted my existing `cordova-ios@4.0.1` project to using the asset
catalogs. The splashscreen plugin appears to be looking for the `Default` filename instead
of `LaunchImage`.
    
    I do not have a `UILaunchImageFile` key in my plist anymore (and note the template does
not either). Isn't the logic here backwards -- if the `UILaunchImageFile` key exists then
that's the filename to use, otherwise it should use `LaunchImage` and assume it's in an asset
catalog? Or will that break compatibility for folks who assume the default filenames are used
without adding it to the plist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message