cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...
Date Fri, 19 Feb 2016 11:49:39 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53451788
  
    --- Diff: src/android/SplashScreen.java ---
    @@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog) {
                         }
                     });
     
    -                spinnerDialog.setCancelable(false);
    +                if(preferences.getBoolean("spinnerCancelable",true)){
    --- End diff --
    
    Should not the property be `false` by default (noncancellable)?
    You are changing the default plugin behavior as it is optional.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message