cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: New plugin version selection implementat...
Date Thu, 18 Feb 2016 10:58:08 GMT
Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/363#discussion_r53299072
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -154,6 +135,38 @@ module.exports = function plugin(command, targets, opts) {
                                 is_top_level: true
                             };
     
    +                        // If no version is specified, retrieve the version (or source)
from config.xml
    +                        if (!version && !cordova_util.isUrl(id) && !cordova_util.isDirectory(id))
{
    +                            events.emit('verbose', 'no version specified, retrieving
version from config.xml');
    +                            var ver = getVersionFromConfigFile(id, cfg);
    --- End diff --
    
    I know this is just moved code, but while you're here could you make that sentence start
with an uppercase "N" (as in "No version specified...")? :smile: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message