cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-10640: Windows logging is broken
Date Wed, 17 Feb 2016 23:07:35 GMT
Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/151#discussion_r53247225
  
    --- Diff: template/cordova/lib/log.js ---
    @@ -47,10 +47,10 @@ var appTracingInitialState = null,
      * and prints them to console
      */
     module.exports.run = function(args) {
    -    var startTime = new Date(new Date().getTime() - 10 * 60 * 1000).toISOString(), //
show last 10 minutes by default
    -        knownOpts = { 'minutes' : Number, 'dump' : Boolean, 'help' : Boolean },
    -        shortHands = { 'mins' : ['--minutes'], 'h' : ['--help'] },
    -        parsedOpts = nopt(knownOpts, shortHands, args, 0);
    +    var startTime  = 10 * 60 * 1000; // show last 10 minutes by default
    --- End diff --
    
    Nitpick: It would be nice to rename startTime to something else. It isn't really a start
time anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message