cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <>
Subject [GitHub] cordova-android pull request: CB-10628 Fix emulate android --targe...
Date Wed, 17 Feb 2016 20:15:34 GMT
Github user daserge commented on the pull request:
    @vladimir-kotikov, addressed, thanks.
    @nikhilkh, I've tried to test private `getInstallTarget` with `rewire` but faced an issue
caused by the fact that the test-time directory structure differs from the run-time one (so
that `check-reqs` fails to load when rewire requires run -> emulator -> check_reqs):
    var rewire = require("rewire");
    var run = rewire("../../bin/templates/cordova/lib/run");
    var getInstallTarget = run.__get__("getInstallTarget");
    describe("run", function () {
      describe("getInstallTarget", function() {
        var targetOpts = { target: "emu" };
        var deviceOpts = { device: true };
        var emulatorOpts = { emulator: true };
        var emptyOpts = {};
        it("should select correct target based on the run opts", function() {

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message