cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10518 Correct log level and error mes...
Date Tue, 16 Feb 2016 18:42:46 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/383#discussion_r53056714
  
    --- Diff: cordova-lib/src/cordova/compile.js ---
    @@ -40,7 +40,7 @@ module.exports = function compile(options) {
         }).then(function() {
             return hooksRunner.fire('after_compile', options);
         }, function(error) {
    -        events.emit('log', 'ERROR building one of the platforms: ' + error + '\nYou may
not have the required environment or OS to build this project');
    +        events.emit('warn', 'ERROR building one of the platforms: ' + error + '\nYou
may not have the required environment or OS to build this project');
    --- End diff --
    
    Let's remove the warning if it's not needed and looks like other commands do not log anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message