cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10550 Fixed the issue of plugin id ma...
Date Tue, 16 Feb 2016 07:38:33 GMT
Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/387#discussion_r52976299
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -132,10 +132,14 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
                     ));
                 }
                 // If not found in local search path, fetch from the registry.
    -            var newID = pluginMapperotn[plugin_src];
    +            var splitVersion = plugin_src.split('@');
    +            var newID = pluginMapperotn[splitVersion[0]];
                 if(newID) {
                     events.emit('warn', 'Notice: ' + plugin_src + ' has been automatically
converted to ' + newID + ' to be fetched from npm. This is due to our old plugins registry
shutting down.');                
    --- End diff --
    
    Looks great, thanks @bso-intel!
    
    One small nit - use `splitVersion[0]` in the message instead of `plugin_src` (so, for
example, we get `org.apache.cordova.device has been automatically converted to cordova-plugin-device
to be fetched from npm` instead of `org.apache.cordova.device@1.1.1 has been automatically
converted to cordova-plugin-device to be fetched from npm`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message