cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: CB-10574: MobileSpec can'...
Date Mon, 15 Feb 2016 13:35:57 GMT
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/70#issuecomment-184211059
  
    @sarangan12, LGTM, thank you for updating the PR!
    
    A few notes:
    
    - Could you please add a fallback for [Number.EPSILON](https://github.com/sarangan12/cordova-plugin-geolocation/commit/a6da270a0bb8d6c83911d8d559c1bb37abe7bbcc#diff-670b1e761968f9ba2d95017f9a8a6187L169)
as it is undefined on Windows Phone 8.1?
    - [success](https://github.com/sarangan12/cordova-plugin-geolocation/commit/a6da270a0bb8d6c83911d8d559c1bb37abe7bbcc#diff-670b1e761968f9ba2d95017f9a8a6187L190)
is null in clearWatch so does it make sense to verify it has a value before executing it?
(`success && success()`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message