cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: CB-10574: MobileSpec can'...
Date Sat, 13 Feb 2016 01:39:23 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/70#discussion_r52820086
  
    --- Diff: src/windows/GeolocationProxy.js ---
    @@ -14,47 +14,43 @@
      * limitations under the License.
      */
     
    -var PositionError = require('./PositionError'),
    -    ids = {},
    -    loc;
    +var PositionError   = require('./PositionError');
    +var ids             = {};
    --- End diff --
    
    Nitpick: `ids` is not a very descriptive name. This object holds on to subscribed callbacks,
so maybe rename it to something related to that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message