cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10592 Don't quote platform specific a...
Date Fri, 12 Feb 2016 20:49:34 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/386#discussion_r52796519
  
    --- Diff: cordova-lib/src/cordova/util.js ---
    @@ -297,7 +297,7 @@ function ensurePlatformOptionsCompatible (platformOptions) {
         }).map(function (arg) {
             return opts[arg] === true ?
                 '--' + arg :
    -            '--' + arg + '="' + opts[arg].toString() + '"';
    +            '--' + arg + '=' + opts[arg].toString();
    --- End diff --
    
    I hope so. We're actually already emitting a warning when arguments used this way, so
we could try to get rid of this in next major release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message