cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10518 Correct log level and error mes...
Date Fri, 12 Feb 2016 18:58:28 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/383#discussion_r52782573
  
    --- Diff: cordova-lib/src/cordova/targets.js ---
    @@ -25,9 +25,9 @@ var cordova_util = require('./util'),
     
     function handleError(error) {
         if (error.code === 'ENOENT') {
    -        events.emit('log', 'Platform does not support ' + this.script);
    +        events.emit('warn', 'Platform does not support ' + this.script);
         } else {
    -        events.emit('log', 'An unexpected error has occured');
    +        events.emit('warn', 'An unexpected error has occured while running ' + this.script);
    --- End diff --
    
    Should we log the error code? It's often useful to have that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message