cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <>
Subject [GitHub] cordova-lib pull request: CB-10518 Correct log level and error mes...
Date Fri, 12 Feb 2016 18:55:29 GMT
Github user nikhilkh commented on a diff in the pull request:
    --- Diff: cordova-lib/src/cordova/create.js ---
    @@ -191,8 +191,8 @@ function create(dir, optionalId, optionalName, cfg) {
                     return remoteLoad.gitClone(gitURL, branch).fail(
                         function(err) {
    -                        events.emit('verbose', err);
    -                        return Q.reject('Failed to retrieve '+ cfg.lib.www.url + ' using
    +                        events.emit('warn', err.message);
    +                        return Q.reject(new CordovaError('Failed to retrieve '+ cfg.lib.www.url
+ ' using git.'));
    --- End diff --
    Should the `err.message` be appended to new CordovaError or the original `err` be passed
as inner error?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message