cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: CB-10574: MobileSpec can'...
Date Fri, 12 Feb 2016 16:00:04 GMT
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/70#issuecomment-183385836
  
    The geolocation plugin has several issues:
    
    1. `geolocation.js->getCurrentPosition` and `geolocation.js->watchPosition` both
don't immediately return `timerId`/`watchId` therefore the tests `watchPosition method->error
callback->geolocation.spec.7`, `watchPosition method->error callback->geolocation.spec.10`
and `success callback->geolocation.spec.8` get their errorWatch/successWatch(es) mixed.
    
    2. On Windows after Geolocator had some of the event handlers attached we can't set any
of its properties like `desiredAccuracy`, `reportInterval` or `movementThreshold` as this
causes "0x80004004 - JavaScript runtime error: Operation aborted".
    
    Related SO question: http://stackoverflow.com/questions/13720945/is-it-possible-to-change-desiredaccuracy-reportinterval-of-geolocator-in-posit
    
    3. Manual test for `addWatch` doesn't clear the previous `watchId` so it's causing the
issues on Windows.
    
    I will update my PR soon with these issues addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message