cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <>
Subject [GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x
Date Fri, 12 Feb 2016 03:51:17 GMT
Github user dblotsky commented on a diff in the pull request:
    --- Diff: tools/bin/incrementversion.js ---
    @@ -36,9 +36,11 @@ function isValidVersion(version) {
         if (version == DEV_VERSION_NAME) {
             return false;
    +    /*
         if (!semver.valid(version)) {
    --- End diff --
    Please add a `validVersion` function here, just with some simpler logic. A test `\d\.x`
should probably be fine.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message