cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tripodsan <...@git.apache.org>
Subject [GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...
Date Thu, 11 Feb 2016 23:51:03 GMT
Github user tripodsan commented on a diff in the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52687280
  
    --- Diff: cordova-plugin-mobilespec-tests/tests/datauri.tests.js ---
    @@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
     
             function onMessage(done, msg) {
                 if (msg.data == 'foo') {
    +                expect('Suppress SPEC HAS NO EXPECTATIONS').toBeDefined();
    --- End diff --
    
    it's not my code...I just fixed the warning :-) I think the test has no expectations because
it just needs to wait for the async() to finish. Also, I think this warning was fixed in a
more modern jasmine version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message