cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...
Date Thu, 11 Feb 2016 22:18:44 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52676901
  
    --- Diff: createmobilespec/createmobilespec.js ---
    @@ -498,6 +522,15 @@ function pluginIdToDirName(id) {
     ////////////////////// install plugins for each platform
     function installPlugins() {
         var plugins = DEFAULT_PLUGINS;
    +
    +    // special override for osx
    +    if (argv.osx) {
    +        if (platforms.length > 1) {
    --- End diff --
    
    This will override the plugins for all platforms, which is incorrect behaviour. Perhaps
make the logic override plugins when OSX is the *only* specified platform?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message