cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: CB-10433: Removing the ETIMEDOUT error...
Date Tue, 09 Feb 2016 22:45:07 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/76#discussion_r52387149
  
    --- Diff: medic/medic-run.js ---
    @@ -372,13 +372,13 @@ function main() {
             //      timeout needs to be in milliseconds, but it's
             //      given in seconds, so we multiply by 1000
             testwait.init(couchdbURI);
    -        testwait.waitTestsCompleted(buildId, timeout * 1000).then(
    +        testwait.waitTestsCompleted(buildId, timeout * 1000, false).then(
                 function onFulfilled(value) {
    -                util.medicLog("got test results");
    +                util.medicLog("Successfully found test results");
                     process.exit(0);
                 },
                 function onRejected(error) {
    -                console.error("didn't get test results: " + error);
    +                console.error("Could not find test results: " + error);
    --- End diff --
    
    It will be great to suggest that a failure indicates a crashed app. Checking platform
specific logs for crash reason is a good idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message