cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...
Date Fri, 05 Feb 2016 08:04:05 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: cordova-lib/spec-cordova/metadata/windows_parser.spec.js ---
    @@ -115,31 +110,9 @@ describe('windows8 project parser', function() {
                 read = spyOn(fs, 'readFileSync').andReturn('');
    -        describe('update_from_config method', function() {
    --- End diff --
    Intead of removing these tests could you please update them to test that corresponding
script is being required, and the error is thrown when it is missing.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message