cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakatyal <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-10541: Changing default max...
Date Thu, 04 Feb 2016 22:03:14 GMT
Github user rakatyal commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/162#discussion_r51945199
  
    --- Diff: src/windows/CameraProxy.js ---
    @@ -710,7 +710,10 @@ function takePictureFromCameraWindows(successCallback, errorCallback,
args) {
         var UIMaxRes = WMCapture.CameraCaptureUIMaxPhotoResolution;
         var totalPixels = targetWidth * targetHeight;
     
    -    if (totalPixels <= 320 * 240) {
    +    if (targetWidth == -1 && targetHeight == -1) {
    --- End diff --
    
    If targetWidth and targetHeight are not specified, they are initialized to -1. So even
if we initialize, it will be changed to verySmallQvga in the present if condition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message