cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10430 Allow to modify events source
Date Thu, 04 Feb 2016 20:06:52 GMT
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/370#issuecomment-180026635
  
    Guys, just a couple of ideas, based on discussion with Nikhil:
    1, Instead of overwriting `events` instance in common, platform might set a reference
to `events` on `global` object, which `cordova-common` will check at runtime and use if available
    2. Platform might create a proxy - just subscribe to and redirect `cordova-common`'s `events`
to own instance - this one have an advantage - we would not need for any special logic in
`common` for that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message